[webkit-reviews] review denied: [Bug 89722] Implement undoManager's undo, redo, length, position, clearUndo, and clearRedo : [Attachment 155025] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Sukolsak Sakshuwong
<sukolsak at google.com>'s request for review:
Bug 89722: Implement undoManager's undo, redo, length, position, clearUndo, and
clearRedo
https://bugs.webkit.org/show_bug.cgi?id=89722

Attachment 155025: Patch
https://bugs.webkit.org/attachment.cgi?id=155025&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155025&action=review


> Source/WebCore/bindings/js/JSDOMTransaction.h:66
> +    RefPtr<DOMWrapperWorld> m_isolatedWorld;

We shouldn't have a strong ref to the isolated world. Instead, retrieve this
information from the document as needed.

> Source/WebCore/bindings/v8/V8DOMTransaction.h:62
> +    WorldContextHandle m_worldContext;

We shouldn't be storing the world context. Instead, retrieve it from the
document.

> Source/WebCore/editing/UndoManager.h:53
>  class UndoManager : public RefCounted<UndoManager> {

Per discussion with abarth, this needs to be an active DOM object.