[webkit-reviews] review denied: [Bug 92187] ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &) : [Attachment 154999] Proposed change. Add an |height| check too.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 92187: ASSERTION FAILED: !rect.isEmpty()  : void
WebCore::GraphicsContext::drawRect(const WebCore::IntRect &)
https://bugs.webkit.org/show_bug.cgi?id=92187

Attachment 154999: Proposed change. Add an |height| check too.
https://bugs.webkit.org/attachment.cgi?id=154999&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154999&action=review


> Source/WebCore/rendering/RenderObject.cpp:838
> +    int width = side == BSTop || side == BSBottom ? y2 - y1 : x2 - x1;
> +    int height = side == BSTop || side == BSBottom ? x2 - x1 : y2 - y1;

width and height are confusing here. Maybe rename 'width' to 'thickness', and
'height' to 'length'?

Maybe also use if (top or bottom) { thickness = ; height = } to make it more
clear.