[webkit-reviews] review granted: [Bug 92450] nrwt: remove 'webkit.py' and the 'WebKitPort' : [Attachment 154835] fix base for diff

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 92450: nrwt: remove 'webkit.py' and the 'WebKitPort'
https://bugs.webkit.org/show_bug.cgi?id=92450

Attachment 154835: fix base for diff
https://bugs.webkit.org/attachment.cgi?id=154835&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154835&action=review


This looks right. Please make sure that test-webkitpy & run-webkit-tests run
without errors before you land.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1430
> +    def _skipped_tests_for_unsupported_features(self, test_list):

On my.... This function has waaay too much comment that I can't make sense of
the code.
Could you insert some blank lines so that comments and code aren't mangled
together?
It's impossible to read as is.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1459
> +    def _skipped_file_search_paths(self):

Ditto about code & comments completely mangled together.