[webkit-reviews] review granted: [Bug 92445] [Chromium] HarfBuzzShaper can't handle segmented text run : [Attachment 154810] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 92445: [Chromium] HarfBuzzShaper can't handle segmented text run
https://bugs.webkit.org/show_bug.cgi?id=92445

Attachment 154810: Patch
https://bugs.webkit.org/attachment.cgi?id=154810&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154810&action=review


> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:194
> +    return index >= m_fromIndex && index < m_toIndex;

Nit: I think "m_fromIndex <= index && index < m_toIndex" is a little easier to
read.

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:100
> +    bool shouldDrawCharacter(int index);

Nit: Maybe name this shouldDrawCharacterAt?