[webkit-reviews] review requested: [Bug 92477] REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK : [Attachment 154981] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 92477: REGRESSION (r123767):
platform/gtk/accessibility/object-with-title.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=92477

Attachment 154981: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=154981&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #0)
> platform/gtk/accessibility/object-with-title.html started failing on GTK
after r123767.
> http://trac.webkit.org/changeset/123767/trunk
> [...]
> Perhaps this is actually a progression and the test case should be updated?

Doesn't seem so. It seems the problem is that the <div> holding the second list
is not being exposed (when it should be) because helpText() is not returning
the title attribute, just because it happens to be the same than the
accessibility description (that changed in r123767).

This seems to be a problem for the GTK port because we expect to expose any
object with an accessibility description available, regardless of the value of
helpText(), which GTK doesn't use (it seems only the mac uses it).

So, in order to fix this I propose the current patch, which only affects the
GTK port and that just works on the following simple assumption: if an object
has an accessible description available, it should be exposed. Considering
that, according ARIA specs, the 'title' attribute is the last resort when
calculating the alternative text for an element, I think it's a pretty
reasonable assumption to make.