[webkit-reviews] review granted: [Bug 92261] [gtk] Add wk1 method for snapshotting a webview : [Attachment 154938] [Gtk] Add WK1 API for snapshot retrieval

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 92261: [gtk] Add wk1 method for snapshotting a webview
https://bugs.webkit.org/show_bug.cgi?id=92261

Attachment 154938: [Gtk] Add WK1 API for snapshot retrieval
https://bugs.webkit.org/attachment.cgi?id=154938&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154938&action=review


Looks good to me apart from two minor changes!

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5273
> +webkit_web_view_get_snapshot(WebKitWebView *webView)

The asterisk should be up against the type here.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5284
> +    cairo_surface_t* surface =
cairo_image_surface_create(CAIRO_FORMAT_RGB24, allocation.width,
allocation.height);

Changing this to CAIRO_FORMAT_ARGB32 and adding a clearRect (see the call in
ChromeClient) below would ensure that transparent backgrounds work.