[webkit-reviews] review denied: [Bug 92075] Implement datalist UI for input type color for Chromium : [Attachment 154911] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92075: Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Attachment 154911: Patch
https://bugs.webkit.org/attachment.cgi?id=154911&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154911&action=review


> Source/WebKit/chromium/src/ColorChooserUIController.cpp:95
> +    return WebCore::IntSize(0, 0);

It should have non-0 height.  If not, the popup might be invisible in a case
that <input type=color> is at the bottom of the view.

>
LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-appearan
ce.html:21
> +<datalist id=gray>
> +    <option>#ffffff</option>
> +    <option>#eeeeee</option>
> +    <option>#dddddd</option>
> +    <option>#cccccc</option>
> +    <option>#bbbbbb</option>
> +    <option>#aaaaaa</option>
> +    <option>#999999</option>
> +    <option>#888888</option>
> +    <option>#777777</option>
> +    <option>#666666</option>
> +    <option>#555555</option>
> +    <option>#444444</option>
> +    <option>#333333</option>
> +    <option>#222222</option>
> +    <option>#111111</option>
> +    <option>#000000</option>
> +</datalist>

It should contain some invalid color strings.