[webkit-reviews] review denied: [Bug 74040] Fails to build QtWebKit on QNX : [Attachment 147345] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Milian Wolff
<milian.wolff at kdab.com>'s request for review:
Bug 74040: Fails to build QtWebKit on QNX
https://bugs.webkit.org/show_bug.cgi?id=74040

Attachment 147345: Patch
https://bugs.webkit.org/attachment.cgi?id=147345&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147345&action=review


This is going to need another iteration, I'm missing explanations (either in
this bug or in the ChangeLog) as to why certain changes were made.

>> Source/WTF/wtf/DisallowCType.h:43
>> +#if !PLATFORM(QT) && !PLATFORM(WX) && !OS(QNX)
> 
> Add bug number?

Can you explain why you're moving the code block from config.h into this file?

> Source/WTF/wtf/Platform.h:493
> +#if OS(QNX) || PLATFORM(BLACKBERRY)
> +#define USE_SYSTEM_MALLOC 1
> +#endif

what's the difference between OS(QNX) and PLATFORM(BLACKBERRY)? Does the latter
also include the non-QNX based blackberry platforms?