[webkit-reviews] review granted: [Bug 79117] [chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes). : [Attachment 127981] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Oli Lan <olilan at chromium.org>'s
request for review:
Bug 79117: [chromium] Fix issues in visiblePositionForWindowPoint (offscreen
points / iframes).
https://bugs.webkit.org/show_bug.cgi?id=79117

Attachment 127981: Patch
https://bugs.webkit.org/attachment.cgi?id=127981&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
We really should write tests for this sort of patch.  I feel a bit like I'm
encouraging bad behavior by approving this patch, but I also want you to
encourage you to submit patches to WebKit.  On balance, I'm going to r+ this
patch, but please include tests with future patches.  You should also feel
encouraged to upload a followup patch that contains a patch.  If you're unsure
how to write a test for this issue, I'm happy to help.