[webkit-reviews] review denied: [Bug 92075] Implement datalist UI for input type color for Chromium : [Attachment 154867] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92075: Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Attachment 154867: Patch
https://bugs.webkit.org/attachment.cgi?id=154867&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154867&action=review


> Source/WebCore/platform/ColorChooserClient.h:23
> +    virtual IntRect elementRectRelativeToRootView() const = 0;
>      virtual IntRect elementRectRelativeToWindow() const = 0;

Adding another similar API is not acceptable.

ColorChooserClient::elementRectRelativeToWindow() is not used yet, and Pierre
Rossi is about to use it in Bug 91664.	You need to discuss this with him.