[webkit-reviews] review denied: [Bug 92075] Implement datalist UI for input type color for Chromium : [Attachment 154848] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92075: Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Attachment 154848: Patch
https://bugs.webkit.org/attachment.cgi?id=154848&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154848&action=review


> Source/WebKit/chromium/src/ColorChooserUIController.cpp:138
> +    m_popup = m_chromeClient->openPagePopup(this,
m_client->elementRectRelativeToWindow());

PagePopup API assumes the second argument is a rectangle relative to the
RootView, not Window.  See WebCore/platform/ScrollView.h.

> Source/WebKit/chromium/src/ColorChooserUIController.cpp:152
> +    WebColor webColor =
static_cast<WebColor>(m_client->currentColor().rgb());
> +    m_chooser = m_chromeClient->createWebColorChooser(this, webColor);

The local variable 'webColor' is unnecessary.

> Source/WebKit/chromium/src/ColorChooserUIController.h:35
> +#define ColorChooserUIController_h
> +
> +#include "ColorChooser.h"
> +#include "PagePopupClient.h"
> +#include "WebColorChooserClient.h"
> +#include <wtf/OwnPtr.h>
> +#include <wtf/PassOwnPtr.h>
> +
> +#if ENABLE(INPUT_TYPE_COLOR)

#if ENABLE(INPUT_TYPE_COLOR) should be put between #define
ColorChooserUIController_h and #include "ColorChooser.h".

> LayoutTests/platform/chromium/TestExpectations:3474
> +BUGWK92444 : fast/forms/color/color-suggestion-picker-appearance.html =
MISSING IMAGE

needs to prepend platform/chromium/