[webkit-reviews] review denied: [Bug 92458] Adding NULL checks for editor client within Page object : [Attachment 154842] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 92458: Adding NULL checks for editor client within Page object
https://bugs.webkit.org/show_bug.cgi?id=92458

Attachment 154842: Patch
https://bugs.webkit.org/attachment.cgi?id=154842&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154842&action=review


> Source/WebCore/ChangeLog:10
> +	   No new tests as no change in functionality. Just addition of check
to avoid crash.

That's not true. If this can never cause a crash, then we don't have to do null
check.
If WebKit were to crash without these null checks, then there is a behavior
change.

Please try to come up with a test. It's okay if you could not come up with a
test if it's too hard to do so
but please don't say that there is no behavior change in WebKit, when there is
one.