[webkit-reviews] review denied: [Bug 92075] Implement datalist UI for input type color for Chromium : [Attachment 154822] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92075: Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Attachment 154822: Patch
https://bugs.webkit.org/attachment.cgi?id=154822&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154822&action=review


> Source/WebKit/chromium/ChangeLog:21
> +	   * src/ColorChooserUIController.cpp: Added.

The patch doen't have this file.

> Source/WebCore/platform/LocalizedStrings.h:221
> -#endif
> +#endif    

Do not touch this file.

> LayoutTests/ChangeLog:9
> +	   * fast/forms/color/color-suggestion-picker-appearance-expected.txt:
Added. Tests color suggestion picker popup appearance.
> +	   * fast/forms/color/color-suggestion-picker-appearance.html: Added.

Probably we had better move the test to platform/chromium/fast/forms/color/
because the color suggestion UI might be used only in Chromium.

> LayoutTests/platform/chromium/TestExpectations:3650
>  BUGWK92297 DEBUG : media/video-set-rate-from-pause.html = PASS CRASH
> +
> +// Needs rebaseline.
> +BUGWK92444 WIN LINUX :
fast/forms/color/color-suggestion-picker-appearance.html = IMAGE

I don't recommend to append an entry at the bottom of this file.  It is very
easy to cause a conflict.