[webkit-reviews] review granted: [Bug 92447] nrwt: move image diffing code to a separate module : [Attachment 154808] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 92447: nrwt: move image diffing code to a separate module
https://bugs.webkit.org/show_bug.cgi?id=92447

Attachment 154808: Patch
https://bugs.webkit.org/attachment.cgi?id=154808&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154808&action=review


> Tools/ChangeLog:11
> +	   ImageDiff after a single invocation, and thus we subsequent

Nit: thus we subsequent

> Tools/Scripts/webkitpy/layout_tests/port/image_diff.py:48
> +	   self._proc = None

Please spell out process. "proc" may refer to procedure, which I initially
thought it was referring to.

> Tools/Scripts/webkitpy/layout_tests/port/image_diff.py:62
> +			       len(actual_contents), actual_contents,
> +			       len(expected_contents), expected_contents))

Ditto about aligning indentation at (.

> Tools/Scripts/webkitpy/layout_tests/port/image_diff.py:64
> +	   except IOError as e:

Please spell out exception.