[webkit-reviews] review denied: [Bug 91907] Implement setRangeText() on text controls : [Attachment 154797] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 91907: Implement setRangeText() on text controls
https://bugs.webkit.org/show_bug.cgi?id=91907

Attachment 154797: Patch
https://bugs.webkit.org/attachment.cgi?id=154797&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154797&action=review


> Source/WebCore/html/HTMLTextFormControlElement.cpp:245
> +    if (!isTextFormControl())
> +	   return;

According to the standard, we should throw InvalidStateError.
Also, HTMLInputElement::isTextFormControl() implementation is wrong. We
shouldn't support setRangeText() only for text, search, url, tel, and password.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.h
tml#input-type-attr-summary


http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-cont
rols-and-forms.html#textFieldSelection
> When these methods and attributes are used with input elements while they
don't apply, they must throw an InvalidStateError exception.