[webkit-reviews] review granted: [Bug 91592] [EFL] Highlight the element under mouse on web inspector : [Attachment 154473] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Seokju Kwon
<seokju.kwon at samsung.com>'s request for review:
Bug 91592: [EFL] Highlight the element under mouse on web inspector
https://bugs.webkit.org/show_bug.cgi?id=91592

Attachment 154473: Patch
https://bugs.webkit.org/attachment.cgi?id=154473&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154473&action=review


Looks OK. rs=me

>>> Source/WebKit/efl/ewk/ewk_paint_context.cpp:181
>>> +	     WebCore::InspectorController* controller =
page->inspectorController();
>> 
>> I wonder if page always has inspector controller. If not, I think below
condition is good to avoid crash.
>> 
>> if (WebCore::InspectorController* controller = page->inspectorController())
>>     if (controller->highlightedNode())
>>	   controller->drawHighlight(*context->graphicContext);
> 
> It seems to me that page always has inspectorController.

Looks so to me too.