[webkit-reviews] review granted: [Bug 92320] HTMLAppletElement should inherit from HTMLPlugInImageElement : [Attachment 154753] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 92320: HTMLAppletElement should inherit from HTMLPlugInImageElement
https://bugs.webkit.org/show_bug.cgi?id=92320

Attachment 154753: Patch
https://bugs.webkit.org/attachment.cgi?id=154753&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154753&action=review


This seems reasonable to me.  It's very difficult to verify that this is
correct from just seeing the code.  I hope we have testing... :)

> Source/WebCore/html/HTMLAppletElement.cpp:42
> +    : HTMLPlugInImageElement(tagName, document, createdByParser,
ShouldNotPreferPlugInsForImages)

ShouldNotPreferPlugins?

> Source/WebCore/html/HTMLAppletElement.cpp:153
> +   
renderer->setWidget(frame->loader()->subframeLoader()->createJavaAppletWidget(r
oundedIntSize(LayoutSize(contentWidth, contentHeight)), this, paramNames,
paramValues));

Do we worry that we're now going to be exposing a different set of params to
the java plugin? It's not clear to me that we are, but is one possible concern
here.