[webkit-reviews] review denied: [Bug 84041] Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload : [Attachment 154754] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 14:39:36 PDT 2012


Brady Eidson <beidson at apple.com> has denied Jeffrey Pfau
<jeffrey at endrift.com>'s request for review:
Bug 84041: Reloading substitute-data/alternate html string for unreachableURL
will add an item to the back-forward-history for each reload
https://bugs.webkit.org/show_bug.cgi?id=84041

Attachment 154754: Patch
https://bugs.webkit.org/attachment.cgi?id=154754&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154754&action=review


> Tools/ChangeLog:13
> +	   * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
> +	   * TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
> +	   (-[BackForwardListTest webView:didFinishLoadForFrame:]):
> +	   (-[BackForwardListTest
webView:didFailProvisionalLoadWithError:forFrame:]):
> +	   (TestWebKitAPI):
> +	   (TestWebKitAPI::TEST):

BackForwardList.mm doesn't appear to be included in this diff...?


More information about the webkit-reviews mailing list