[webkit-reviews] review granted: [Bug 92278] IndexedDB: Pass cursor continue results back in callback : [Attachment 154738] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 13:47:46 PDT 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 92278: IndexedDB: Pass cursor continue results back in callback
https://bugs.webkit.org/show_bug.cgi?id=92278

Attachment 154738: Patch
https://bugs.webkit.org/attachment.cgi?id=154738&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154738&action=review


> Source/WebKit/chromium/public/WebIDBCallbacks.h:63
> +    virtual void onSuccess(const WebIDBKey&, const WebIDBKey&, const
WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }

nit: two key parameters... might help to have names to differentiate them.


More information about the webkit-reviews mailing list