[webkit-reviews] review granted: [Bug 92160] [BlackBerry] Support async spellcheck for the blackberry port : [Attachment 154708] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 92160: [BlackBerry] Support async spellcheck for the blackberry port
https://bugs.webkit.org/show_bug.cgi?id=92160

Attachment 154708: Patch
https://bugs.webkit.org/attachment.cgi?id=154708&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154708&action=review


Looks good, please fix the minor issues.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:523
> +void
InputHandler::requestCheckingOfString(WTF::PassRefPtr<WebCore::TextCheckingRequ
est> textCheckingRequest)

You can remove the WTF:: prefixes here.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:560
> +    // map sequenceId to transactionId

Add a period.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:619
> +	   InputLog(LogLevelWarn, "InputHandler::spellCheckingRequestProcessed
failed to processed request with sequenceId %d", sequenceId);

Typo process