[webkit-reviews] review granted: [Bug 92401] Guard Prerenderer against inserting prerenders into detached documents. : [Attachment 154692] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 26 11:31:06 PDT 2012
Nate Chapin <japhet at chromium.org> has granted Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 92401: Guard Prerenderer against inserting prerenders into detached
documents.
https://bugs.webkit.org/show_bug.cgi?id=92401
Attachment 154692: Patch
https://bugs.webkit.org/attachment.cgi?id=154692&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154692&action=review
> LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop.html:8
> + if (window.testRunner) {
> + testRunner.notifyDone();
> + }
Nit, no braces.
> LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop.html:14
> + setTimeout(done, 0);
Obligatory: any chance of avoiding the setTimeout()?
More information about the webkit-reviews
mailing list