[webkit-reviews] review granted: [Bug 92210] [Chromium] an RTL <select> element should have a left-hand scrollbar : [Attachment 154598] Patch v0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 11:12:19 PDT 2012


Tony Chang <tony at chromium.org> has granted Hironori Bono <hbono at chromium.org>'s
request for review:
Bug 92210: [Chromium] an RTL <select> element should have a left-hand scrollbar
https://bugs.webkit.org/show_bug.cgi?id=92210

Attachment 154598: Patch v0
https://bugs.webkit.org/attachment.cgi?id=154598&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154598&action=review


> Source/WebCore/rendering/RenderListBox.cpp:276
> +    return LayoutRect(left,
>		      additionalOffset.y() + borderTop() + paddingTop() +
itemHeight() * (index - m_indexOffset),
>		      contentWidth(), itemHeight());

Nit: I think the indent is meant to line up with the opening (.


More information about the webkit-reviews mailing list