[webkit-reviews] review granted: [Bug 92343] [EFL][WK2] Implement Network Information provider : [Attachment 154666] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 92343: [EFL][WK2] Implement Network Information provider
https://bugs.webkit.org/show_bug.cgi?id=92343

Attachment 154666: Patch
https://bugs.webkit.org/attachment.cgi?id=154666&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154666&action=review


r=me as you are basically just moving this around

> Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp:59
> +    // FIXME : This function should consider cellular network as well. For
example, 2G, 3G and 4G.
> +    // See https://bugs.webkit.org/show_bug.cgi?id=89851 for detail.
> +    Eeze_Net* ethNet = eeze_net_new(ethernetInterface);

didn't the spec change so that is not necessary anymore? The bug report says
almost nothing

> Source/WebCore/platform/efl/NetworkInfoProviderEfl.cpp:61
> +    if (!ethNet)
> +	   return 0;

so 0 is unknown? What does the spec say?