[webkit-reviews] review granted: [Bug 92265] Web Inspector: SASS source mapping straw man (behind experiment) : [Attachment 154382] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 92265: Web Inspector: SASS source mapping straw man (behind experiment)
https://bugs.webkit.org/show_bug.cgi?id=92265

Attachment 154382: Patch
https://bugs.webkit.org/attachment.cgi?id=154382&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154382&action=review


> Source/WebCore/inspector/front-end/SASSSourceMapping.js:98
> +		   var rawLocation = resource.url + ":" + (lineNumber + 1);

Please use another name (e.g. rawLocationString or rawLocationId) for this
variable as it is not a RawLocation.

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:128
> +	   return new WebInspector.CSSLocation(uiSourceCode.contentURL() || "",
lineNumber);

Please add a FIXME: comment saying this is a stub implementation