[webkit-reviews] review granted: [Bug 92373] Web Inspector: Move formatting support from JavaScriptSource to UISourceCode. : [Attachment 154649] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 92373: Web Inspector: Move formatting support from JavaScriptSource to
UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373

Attachment 154649: Patch
https://bugs.webkit.org/attachment.cgi?id=154649&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154649&action=review


> Source/WebCore/inspector/front-end/JavaScriptSource.js:51
>      uiLocationToRawLocation: function(lineNumber, columnNumber)

I don't think you need this method.

> Source/WebCore/inspector/front-end/Script.js:223
> +    uiLocation: function()

This looks like a great self-contained change.

> Source/WebCore/inspector/front-end/ScriptFormatter.js:35
> +WebInspector.Formatter = function(workerURL)

I don't think we should imply that the formatter is implemented using worker.

> Source/WebCore/inspector/front-end/UISourceCode.js:411
> +    uiLocationToRawLocation: function(lineNumber, columnNumber)

You should move it back.