[webkit-reviews] review denied: [Bug 92381] Import the Android Test Runner scripts : [Attachment 154653] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 08:48:27 PDT 2012


Adam Barth <abarth at webkit.org> has denied Peter Beverloo <peter at chromium.org>'s
request for review:
Bug 92381: Import the Android Test Runner scripts
https://bugs.webkit.org/show_bug.cgi?id=92381

Attachment 154653: Patch
https://bugs.webkit.org/attachment.cgi?id=154653&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154653&action=review


> Tools/Scripts/webkitpy/thirdparty/android_testrunner/LICENSE:4
> +				    Apache License
> +			      Version 2.0, January 2004
> +			   http://www.apache.org/licenses/

I don't think the Apache license is allowed in WebKit.	We're allowed to use
LGPL 2.1, BSD, and MIT (because MIT is essentially the same as BSD).

Typically when we want to use third party Python code that can't be stored in
svn.webkit.org we use autoinstall to download the code on the client.


More information about the webkit-reviews mailing list