[webkit-reviews] review denied: [Bug 92231] [Qt][WK2] REGRESSION(r123583): Removing a test made 88 tests flakey : [Attachment 154378] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 08:03:59 PDT 2012


Simon Hausmann <hausmann at webkit.org> has denied Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 92231: [Qt][WK2] REGRESSION(r123583): Removing a test made 88 tests flakey
https://bugs.webkit.org/show_bug.cgi?id=92231

Attachment 154378: Patch
https://bugs.webkit.org/attachment.cgi?id=154378&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154378&action=review


> Tools/WebKitTestRunner/TestController.cpp:432
> +    if (m_eventSenderProxy)
> +	   delete m_eventSenderProxy;

You don't need to check m_eventSenderProxy for being non-null before deleting
it. delete 0 is fine :)

However I don't think this approach is quite right. It _seems_ the cause is the
event queues in the event sender proxy, which is something only non-mac ports
"suffer" from.

Either our approach of leapForward should be imlemented differently (can we
specify time stamps in the events like mac?) or perhaps we are missing some
sort of reset() call here in resetStateToConsistentValues() that clears the
queue and has a comment explaining why. Deleting and re-creating the event
sender proxy is just hiding the real problem IMHO.


More information about the webkit-reviews mailing list