[webkit-reviews] review denied: [Bug 90262] [Qt][WTR] Get rid of using DumpRenderTreeSupportQt : [Attachment 154410] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 90262: [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
https://bugs.webkit.org/show_bug.cgi?id=90262

Attachment 154410: Patch
https://bugs.webkit.org/attachment.cgi?id=154410&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154410&action=review


I think the patch is good, I like this approach. But it appears to break the
Gtk build, the EWS failure seems valid.

> Source/WebCore/ChangeLog:3
> +	   [Qt][WTR] Get rid of using DumpRenderTreeSupportQt

I think the title is a bit generic, what about renaming it to "Get rid of
DumpRenderTreeSupportQt::injectInternals wrapper"?