[webkit-reviews] review denied: [Bug 91759] Web Inspector: count RenderStyle objects in the native memory profiler : [Attachment 153820] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 07:20:58 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 91759: Web Inspector: count RenderStyle objects in the native memory
profiler
https://bugs.webkit.org/show_bug.cgi?id=91759

Attachment 153820: Patch
https://bugs.webkit.org/attachment.cgi?id=153820&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153820&action=review


> Source/WebCore/rendering/style/RenderStyle.cpp:1507
> +    COMPILE_ASSERT(sizeof(RenderStyle) == sizeof(InstrumentedRenderStyle),
reportMemoryUsage_may_need_an_update);

Let's remove such checks as there were objections against the approach on
webkit-dev. The validation tool that Ilya has been working on should give us
enough confidence in the instrumentation code correctness.


More information about the webkit-reviews mailing list