[webkit-reviews] review granted: [Bug 92301] [BlackBerry] readPixels on FBOs are limited to canvas size on SGX platforms : [Attachment 154642] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Joshua Netterfield
<jnetterfield at rim.com>'s request for review:
Bug 92301: [BlackBerry] readPixels on FBOs are limited to canvas size on SGX
platforms
https://bugs.webkit.org/show_bug.cgi?id=92301

Attachment 154642: Patch
https://bugs.webkit.org/attachment.cgi?id=154642&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154642&action=review


Better :)

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:127
> +	   ::glReadPixels(x, y, width, height, GL_RGBA, GL_UNSIGNED_BYTE,
pixels);

You do the same thing twice, could add a helper method for that, but as we
discussed can be done later.