[webkit-reviews] review denied: [Bug 92075] Implement datalist UI for input type color for Chromium : [Attachment 154612] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92075: Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Attachment 154612: Patch
https://bugs.webkit.org/attachment.cgi?id=154612&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154612&action=review


> Source/WebKit/chromium/ChangeLog:23
> +	   (WebKit::ColorChooserUI::ColorChooserUI): Controls the UI for color
chooser. Opens the color suggestion picker popup or color chooser depending on
the ColorChooserClient.

The class name ending with 'UI' sounds strange though I don't have a counter
proposal.

> Source/WebCore/platform/LocalizedStrings.h:224
> +#if ENABLE(INPUT_TYPE_COLOR)
> +    String otherColorLabel();
>  #endif

This function isn't used by WebCore.  We should remove it.
ColorChooserUI should call WebKit::Platform::current()->queryLocalizedString()
directly.

> LayoutTests/ChangeLog:9
> +	   * fast/forms/color/color-suggestion-picker-appearance.html: Added.

We need to update TestExpectations for non-Mac platforms.