[webkit-reviews] review granted: [Bug 92336] Add a MediaPlayer API to retrieve the description of the current media engine. : [Attachment 154555] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 92336: Add a MediaPlayer API to retrieve the description of the current
media engine.
https://bugs.webkit.org/show_bug.cgi?id=92336

Attachment 154555: Patch
https://bugs.webkit.org/attachment.cgi?id=154555&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154555&action=review


How about platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h? You
could also change Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h, but it
is probably better to just file a bug.

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:134
> +    virtual String engineDescription() const { return ""; }

Did you mean to leave this blank?