[webkit-reviews] review canceled: [Bug 92282] Unify JSC date and time formating functions : [Attachment 154421] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has canceled Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 92282: Unify JSC date and time formating functions
https://bugs.webkit.org/show_bug.cgi?id=92282

Attachment 154421: Patch
https://bugs.webkit.org/attachment.cgi?id=154421&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #2)
> (From update of attachment 154421 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=154421&action=review
> 
> > Source/JavaScriptCore/runtime/DateConversion.cpp:-2
> >  /*
> > - * Copyright (C) 1999-2000 Harri Porten (porten at kde.org)
> 
> This entire file's diff is messed up because of the way git figures out the
move. Please use svn or manually edit the patch so that the diff is readable.

I don't think that I'll ever use svn again, since i switched to git.

> > Source/JavaScriptCore/runtime/DateConversion.h:-2
> >  /*
> > - * Copyright (C) 1999-2000 Harri Porten (porten at kde.org)
> 
> Ditto.

IMHO the header changes should be easy enough to review.