[webkit-reviews] review granted: [Bug 79586] xmlserializer strips xlink from xlink:html svg image tag : [Attachment 154400] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Stephen Chenney
<schenney at chromium.org>'s request for review:
Bug 79586: xmlserializer strips xlink from xlink:html svg image tag
https://bugs.webkit.org/show_bug.cgi?id=79586

Attachment 154400: Patch
https://bugs.webkit.org/attachment.cgi?id=154400&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154400&action=review


Looks great! r=me, with some nitpicks:

> Source/WTF/wtf/text/AtomicString.h:199
> +extern const WTF_EXPORTDATA AtomicString xlinkAtom;

You should add "using WTF::xllinkAtom;" some lines below as well, so we can
make use of this w/o using the WTF:: prefix.

> Source/WebCore/editing/MarkupAccumulator.cpp:441
> +	       if (attribute.prefix() != WTF::xlinkAtom)

WTF:: prefix is unncessary, no? Or is ATOMICSTRING_HIDE_GLOBALS on by default?