[webkit-reviews] review denied: [Bug 88793] Implement undoscope attribute. : [Attachment 154422] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied  review:
Bug 88793: Implement undoscope attribute.
https://bugs.webkit.org/show_bug.cgi?id=88793

Attachment 154422: Patch
https://bugs.webkit.org/attachment.cgi?id=154422&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154422&action=review


Sorry, I wasn't thinking straight when I reviewed this patch. Please add a test
cases where you modify content attribute by calling setAttribute. As is, it
won't do the right thing.

> Source/WebCore/dom/Element.cpp:2199
> +    return fastHasAttribute(HTMLNames::undoscopeAttr);

Ugh... we shouldn't be storing states in attribute like this. What we need to
store it in Element (probably rare data instead).

> Source/WebCore/dom/Element.idl:147
> +	   attribute [Conditional=UNDO_MANAGER] boolean undoScope;

We should have [Reflect] on this.