[webkit-reviews] review denied: [Bug 92302] [WebGL] GraphicsContext3D::readPixels has extraneous code from GraphicsContext3D::readPixelsIMG : [Attachment 154486] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 25 16:55:47 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Joshua Netterfield
<jnetterfield at rim.com>'s request for review:
Bug 92302: [WebGL] GraphicsContext3D::readPixels has extraneous code from
GraphicsContext3D::readPixelsIMG
https://bugs.webkit.org/show_bug.cgi?id=92302

Attachment 154486: Patch
https://bugs.webkit.org/attachment.cgi?id=154486&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154486&action=review


> Source/WebCore/ChangeLog:10
> +
> +	   No new tests, because it introduces no new functionality, but it
makes the WebGL aquarium demo
> +	   run quite a bit smoother on SGX :)
> +

This seems to affect more than the BB port, please explain what this patch
actually does.


More information about the webkit-reviews mailing list