[webkit-reviews] review granted: [Bug 92307] Improve the output of editing/pasteboard/paste-noscript-xhtml.xhtml : [Attachment 154462] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 92307: Improve the output of editing/pasteboard/paste-noscript-xhtml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=92307

Attachment 154462: Patch
https://bugs.webkit.org/attachment.cgi?id=154462&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154462&action=review


> LayoutTests/editing/pasteboard/resources/paste-noscript-content.html:13
> -<iframe id="iframe1" src="javascript:sayHello()" style="width: 200px;
height: 100px; background-color:#cee;"></iframe>
> +<iframe id="iframe1" src="javascript:alert('hello')" style="width: 200px;
height: 100px; background-color:#cee;"></iframe>

Wasn't this testing that sayHello isn't in the same context?  Maybe change it
to something like alert(window.sayHello ? 'FAILED' : 'PASSED: sayHello not
found').