[webkit-reviews] review canceled: [Bug 92237] [BlackBerry] Pass all file chooser settings to clients : [Attachment 154322] patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has canceled Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 92237: [BlackBerry] Pass all file chooser settings to clients
https://bugs.webkit.org/show_bug.cgi?id=92237

Attachment 154322: patch
https://bugs.webkit.org/attachment.cgi?id=154322&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154322&action=review


> Source/WebKit/blackberry/Api/WebPageClient.h:171
> +    virtual bool chooseFilenames(bool allowMultiple, const
SharedArray<WebString>& acceptTypes, unsigned numOfAcceptTypes, const
SharedArray<WebString>& selectedFiles, unsigned numOfselectedFiles, const
WebString& capture, SharedArray<WebString>& chosenFiles, unsigned&
numOfChosenFiles) = 0;

Is it really needed to provide numOfAcceptTypes and numOfselectedFiles? Can't
they be deduced from the SharedArrays?