[webkit-reviews] review granted: [Bug 91976] [WebGL] Initial size of canvas can be larger than MAX_VIEWPORT_DIMS. : [Attachment 154265] Reworked patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 91976: [WebGL] Initial size of canvas can be larger than MAX_VIEWPORT_DIMS.
https://bugs.webkit.org/show_bug.cgi?id=91976

Attachment 154265: Reworked patch
https://bugs.webkit.org/attachment.cgi?id=154265&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154265&action=review


Thanks, looks better. r=me. One comment. Mark cq? if you want this committed as
is.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:523
> +	   m_drawingBuffer->reset(clampedCanvasSize());

How about a local variable instead of calling clampedCanvasSize() five times?

> LayoutTests/fast/canvas/webgl/drawingbuffer-test.html:62
> +test(100, maxSize[1]+100)

In the near future, please align the contents of this test with
conformance/canvas/drawingbuffer-test.html in the WebGL conformance suite. In
general, if we make a code change in WebKit affecting one of the layout tests
that's in the conformance suite, we pull the latest version of the conformance
test back into WebKit as a layout test.