[webkit-reviews] review denied: [Bug 90838] constructing TypedArray from another TypedArray is slow : [Attachment 154429] updated patch to address review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 25 14:44:24 PDT 2012
Kenneth Russell <kbr at google.com> has denied review:
Bug 90838: constructing TypedArray from another TypedArray is slow
https://bugs.webkit.org/show_bug.cgi?id=90838
Attachment 154429: updated patch to address review
https://bugs.webkit.org/attachment.cgi?id=154429&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154429&action=review
Looks good overall. Please address the build failure.
> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:415
> + ArrayBufferView::ViewType type = arrayBufferview->getType();
Typo -- see the cr-linux build results.
More information about the webkit-reviews
mailing list