[webkit-reviews] review granted: [Bug 90998] De-virtualize WrapShape classes : [Attachment 154407] Updated patch for bug 90998

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Anish <bhayani at adobe.com>'s
request for review:
Bug 90998: De-virtualize WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=90998

Attachment 154407: Updated patch for bug 90998
https://bugs.webkit.org/attachment.cgi?id=154407&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154407&action=review


r=me, nice.

> Source/WebCore/rendering/style/WrapShapes.h:62
> +    WrapShape(Type type) 
> +    {
> +	   m_type = type;
> +    }

Nit: we tend to use initializer lists in WebKit, i.e:
WrapShape(Type type)
    : m_type(type)
{ }

> Source/WebCore/rendering/style/WrapShapes.h:166
> -
> +    

Extra whitespace here.