[webkit-reviews] review requested: [Bug 92260] Repalce "int" with "long" from WebCore/*.idls : [Attachment 154415] updated_patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 25 12:25:58 PDT 2012


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 92260: Repalce "int" with "long" from WebCore/*.idls
https://bugs.webkit.org/show_bug.cgi?id=92260

Attachment 154415: updated_patch
https://bugs.webkit.org/attachment.cgi?id=154415&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
(In reply to comment #3)
> It's not clear that they should all be "unsigned long".  You need to check
the specs for each one to see what the correct type is.

Yes not all, only those are "unsinged int" should be repalced with "unsigned
long"  else for "int" with "long".

ArrayBuffer.idl: http://www.khronos.org/registry/typedarray/specs/latest/#5
//Spec says should be unsinged long

Touch.idl:
http://dvcs.w3.org/hg/webevents/raw-file/tip/touchevents.html#idl-def-Touch 
WebKitNamedFlow.idl:
http://www.w3.org/TR/css3-regions/#dom-named-flow-first-empty-region-index 
WebGLActiveInfo.idl: http://www.khronos.org/registry/webgl/specs/latest/#5.11
WebGLShaderPrecisionFormat.idl:
http://www.khronos.org/registry/webgl/specs/latest/#5.12
WebKitAnimation.idl:
http://www.w3.org/TR/css3-animations/#animation-iteration-count


More information about the webkit-reviews mailing list