[webkit-reviews] review granted: [Bug 91665] When a block element is made inline positioned and has static left and right, it does not follow inline formatting context : [Attachment 153630] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 91665: When a block element is made inline positioned and has static left
and right,  it does not follow inline formatting context
https://bugs.webkit.org/show_bug.cgi?id=91665

Attachment 153630: Patch
https://bugs.webkit.org/attachment.cgi?id=153630&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153630&action=review


> Source/WebCore/dom/Node.cpp:374
> +    if (!isS1originalDisplayTypeInline && isS2originalDisplayTypeInline &&
s2->isOutOfFlowPositioned())

This whole patch looks totally reasonable to me.  I was not aware of the
"original display inline type" accessor here.  I also am not 100% sure that
this is the correct way to test for what you're going for.

Why do we need to check the original display type here?  Why not just check
isOutofFlowPositioned() != isOutOfFlowPositioned() between teh two styles? 
That would be a broader net, but it seems it would catch thsi, no?