[webkit-reviews] review denied: [Bug 92228] [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented : [Attachment 154326] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 92228: [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be
implemented
https://bugs.webkit.org/show_bug.cgi?id=92228

Attachment 154326: Patch
https://bugs.webkit.org/attachment.cgi?id=154326&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154326&action=review


> Source/WebKit2/UIProcess/API/C/WKIntentData.cpp:48
> +WKIntentDataRef WKIntentDataCreate(WKIntentData wkIntentData)

Please make WKIntentDataCreate take the action, type and data as individual
parameters instead of using a struct.

> Source/WebKit2/UIProcess/API/C/WKIntentData.h:40
> +struct WKIntentData {
> +    WKStringRef action;
> +    WKStringRef type;
> +    WKSerializedScriptValueRef data;
> +};
> +typedef struct WKIntentData WKIntentData;

Having a struct with public members like this is bad from a memory management
standpoint.