[webkit-reviews] review granted: [Bug 91861] FileSystem should provide a way to delete filesystem. : [Attachment 154143] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 25 10:11:19 PDT 2012


Adam Barth <abarth at webkit.org> has granted Taiju Tsuiki <tzik at chromium.org>'s
request for review:
Bug 91861: FileSystem should provide a way to delete filesystem.
https://bugs.webkit.org/show_bug.cgi?id=91861

Attachment 154143: Patch
https://bugs.webkit.org/attachment.cgi?id=154143&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154143&action=review


> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:237
> +    ASSERT(context->isDocument());

This doesn't exist in workers?

> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:240
> +    WebFrameImpl* webFrame = WebFrameImpl::fromFrame(document->frame());

What if document->frame is null?


More information about the webkit-reviews mailing list