[webkit-reviews] review denied: [Bug 91734] Web Inspector: native memory instrumentation: cover MemoryCache with MemoryInstrumentation : [Attachment 153256] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 91734: Web Inspector: native memory instrumentation: cover MemoryCache with
MemoryInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=91734

Attachment 153256: Patch
https://bugs.webkit.org/attachment.cgi?id=153256&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153256&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:214
> +    template <typename M> void addInstrumentedMember(const M& member,
MemoryInstrumentation::ObjectType objectType = MemoryInstrumentation::Other) {
m_memoryInstrumentation->addInstrumentedMember(member, objectType); }

For members that don't know their type it should be inherited from the owner,
otherwise it is Other so no need to pass objectType explicitly to this method
as it is the same as m_objectType.