[webkit-reviews] review granted: [Bug 92256] [chromium] don't use webkit_support methods directly from test runners but through the test delegate : [Attachment 154360] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 92256: [chromium] don't use webkit_support methods directly from test
runners but through the test delegate
https://bugs.webkit.org/show_bug.cgi?id=92256

Attachment 154360: Patch
https://bugs.webkit.org/attachment.cgi?id=154360&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154360&action=review


> Tools/DumpRenderTree/chromium/TestRunner/GamepadController.h:63
> -    WebKit::WebGamepads internalData;
> +    WebKit::WebGamepads m_internalData;

m_internalData is such a terrible name.  How about m_gamepads?

> Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:73
> -    // m_gamepadController doesn't depend on WebView.
> +    m_gamepadController->setDelegate(0);

I would start a new stanza for setDelegate(0) below the setWebView(0) stanza.