[webkit-reviews] review granted: [Bug 92108] Web Inspector: Resource agent's reference to cached resources should be weak. : [Attachment 154351] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 92108: Web Inspector: Resource agent's reference to cached resources should
be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108

Attachment 154351: Patch
https://bugs.webkit.org/attachment.cgi?id=154351&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154351&action=review


How do we test this?

> Source/WebCore/loader/cache/CachedResource.cpp:434
> +    if (!deleteIfPossible() && !hasClients() && inCache()) {

bool deleted = ...

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:816
> +	   if (!res->deleteIfPossible() && res->preloadResult() ==
CachedResource::PreloadNotReferenced)

ditto