[webkit-reviews] review granted: [Bug 92251] Buildmaster changes in preparation of a Chromium Android tester : [Attachment 154350] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Peter Beverloo
<peter at chromium.org>'s request for review:
Bug 92251: Buildmaster changes in preparation of a Chromium Android tester
https://bugs.webkit.org/show_bug.cgi?id=92251

Attachment 154350: Patch
https://bugs.webkit.org/attachment.cgi?id=154350&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154350&action=review


> Tools/BuildSlaveSupport/built-product-archive:172
> +	   ignorePatterns = ['.svn', '*.a', '*.d', '*.dSYM', '*.o', '*.ilk',
'*.lib', '*.idb',
> +			     'BuildLog.htm', '*.obj', '*.pdb', '*.pch',
'*.tlog', '*.lastbuildstate']
> +
> +	   if fullPlatform and fullPlatform == 'chromium-android':
> +	       ignorePatterns.extend(['*.so', '*.pak', '*-unaligned.apk'])

Should we just ignore these files all the time?  For example, we ignore both
*.obj and *.o even though those never exist on the same OS.