[webkit-reviews] review granted: [Bug 92041] changing -webkit-order should change the paint order of flex items : [Attachment 154169] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai (vacation through 7/31) <ojan at chromium.org> has granted Tony Chang
<tony at chromium.org>'s request for review:
Bug 92041: changing -webkit-order should change the paint order of flex items
https://bugs.webkit.org/show_bug.cgi?id=92041

Attachment 154169: Patch
https://bugs.webkit.org/attachment.cgi?id=154169&action=review

------- Additional Comments from Ojan Vafai (vacation through 7/31)
<ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154169&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:262
> +    m_orderIterator = adoptPtr(new OrderIterator(this, orderValues));

Do we really need the member variable? All this saves is the vector copy + sort
in paintChildren, which will typically be next to 0 cost.